feat: validate local RPC targets independently of transports - #5
Draft
irvinebroque wants to merge 2 commits into
Draft
feat: validate local RPC targets independently of transports#5irvinebroque wants to merge 2 commits into
irvinebroque wants to merge 2 commits into
Conversation
|
I have read the CLA Document and I hereby sign the CLA Brendan Irvine-Broque seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation currently attaches to a class decorator or a transport-specific response helper. That makes it awkward to take an existing object and expose only a chosen interface through another Cap'n Web transport.
validateTarget<PublicApi>(target)adds that missing step: validate the object first, then give it to the transport. It reuses the existing server wrapper to reject undeclared methods and invalid arguments, including on returned capabilities. The interface is inferred when no type argument is supplied.The README and validation guide show usage and explain that native Workers RPC still needs
@validateRpc(), because it requires branded objects rather than proxies. A minor changeset is included.Validation: 617 Node and Workers tests, including a real MessagePort session, plus build, type checks, and Markdown lint pass.