Conversation
commit: |
Author
|
I'm so sorry! An over-eager clanker just created this for me, I can't vouch for it. I will scold/update my AGENTS.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling a remote readable stream now cancels its producer while it is idle. Previously the producer only learned about cancellation when it sent another chunk, leaving SSE producers running indefinitely.
Use the existing rejection message to notify the sender, and pump with an owned reader so cancellation reaches the source. In workerd 1.20260205.0, an idle
pipeTodid not cancel its source after either destination failure or an AbortSignal. The explicit pump preserves write backpressure, forwards source errors, and releases locks without awaiting user cancellation callbacks. Disposed imports also release their failure callbacks instead of retaining them until the session closes.Validation: 612 Node/workerd tests, build and type tests passed. Callback-returned consumed/locked Response cases pass on both runtimes; existing rejection behavior is preserved. The idle-cancellation and session-disconnect regressions failed before their fixes and passes with no leaked RPC imports/exports.
Review focus: stream cancellation and cleanup in
src/rpc.ts, followed by writer failure signaling insrc/streams.ts. No protocol message types added. This PR requests a pkg.pr.new preview for downstream integration testing; no npm release.Codex session:
01a07b03-100a-7803-ba3f-caed48046317