docs: make Fleet a focused chapter in the Workbench teaching path - #335
Conversation
|
Independent final review of 4350bbe: PASS for documentation. Published by the implementing owner from the separate The reading structure works: Workbench 101 supplies purpose and navigation; Fleet 101 follows a focused task → question → handoff → verification path. Org and additional hierarchy remain optional. The long runtime reference is clearly historical. The initial P2 is resolved: dispatch, receipt and completion query now consistently use Independent checks: all 102 relative links/anchors resolve; Owner validation additionally passed Operator-read and no-merge hold remain. This is review evidence, not merge authority. No fourth panel round on #329 was requested. |
|
Status update, 2026-09-14: #334 merged at 00:21:18 UTC as Historical pre-merge status follows: Runtime follow-up: #334 at That repair preserves prior launch/resume evidence and allows mail retry after a constructor failure. It does not recover an already ambiguous |
|
Ready for operator reading at 4350bbe. All five exact-head CI checks passed: check, hygiene, fuzz, macOS seats and Windows seats. Independent final documentation review passed, as posted above. Local Fleet/Org tests, both adapter suites and the corrected CLI walkthrough also passed. The reader path and reference are inspectable in this PR. No newcomer learning trial is claimed, and platform test jobs are not live Windows-provider acceptance. Runtime #334 remains a separate proposed repair. Operator-read/no-merge hold remains; marking ready changes review readiness only. |
|
Merge-preparation refresh, 2026-09-13, exact 4350bbe.
Read the exact guide here: Fleet 101, starting from Workbench 101 if desired. Remaining authority/review requirements:
gate grant -repo itsHabib/workbench -action merge -max-tier T0 -ttl 24h -state ~/dev/gate/stateThe grant covers the repository/action/tier; this task would use it only for #335. After the hold and review requirement are resolved, refresh the exact head, run Gate with the supplied grant and use only Gate's emitted head-pinned merge command. No Gate evaluation, grant mint, merge, installation or deployment was performed during this preparation. |
|
@claude review Please review exact head 4350bbe for the required Claude slot. Focus on the changed teaching path and command semantics, factual safety boundaries, and reconciliation recorded in cmd/fleet/docs/fleet-teaching-validation.md. A separate independent reviewer already caught and verified the receipt-kind fix; both adapters and CI passed. Do not repeat a broad unchanged-runtime audit. Preserve the operator read-through/no-merge hold. This ordinary configured review is authorized by the batch coordinator; no purchase or capacity increase is authorized. |
|
Claude finished @itsHabib's task in 2m 51s —— View job Claude Review — PR #335
|
| Concern from prior reviews | Disposition in this PR |
|---|---|
| Long compulsory first read | New fleet-101.md; old content is optional reference |
| Default hierarchy in README/onboarding | Corrected in ONBOARDING.md §2 and OVERVIEW.md |
| Ownership wording omits shell writes | Corrected in MINIMUM.md, OVERVIEW.md, fleet-101.md |
| Receipts confused with observed truth | receipt/handoff distinction introduced early in fleet-101.md |
| Missing branch before dispatch | Branch creation step added in fleet-101.md and run-a-fleet.md |
| Receipt-kind mismatch (P2) | Corrected: implementation throughout |
| Org parent confused with lateness recipient | Explained correctly in fleet-101.md lines 105–108 |
| Blanket no-Codex claim | Replaced with scoped provider evidence link |
All dispositions are represented accurately in the code. The validation doc's "residuals and stop boundary" section correctly identifies what remains unproven and makes no overclaims. ✓
Minor observations (non-blocking)
-
fleet-101.mdline 99 (address guidance ordering): The guidance to usefrom_addressrather than a role-name guess appears after the example command that uses a placeholder seat address. For a teaching document the ordering is reasonable (learn from example, then see the real-world note), but a reader copy-pasting the command may not read the following paragraph. Not a defect given the explicit placeholder framing. -
fleet-101.md"Source and evidence map" (lines 209–216): The inline source links are relative paths within the checkout and will naturally drift as code evolves. Since the document explicitly pins its checked revision, this is acceptable — the map is a dated audit tool, not a live reference. -
workbench-101.mdline 58 (status marker date):verifiedclaims are dated 2026-09-11 in the Orientation block. This document has a long existing tail; the new front-matter sections (navigation table, "Who owns what") don't carry their own date. This is consistent with how the rest ofworkbench-101.mdworks and is not a new issue introduced here.
Summary
Teaching path: Works. Navigation structure is clear, reading order is unambiguous, and the newcomer can complete the Fleet path without touching the architecture reference.
Command semantics: All commands are syntactically and semantically correct. The branch-prerequisite fix and the receipt-kind consistency fix are both properly implemented.
Factual safety boundaries: Consistently and accurately stated across all eleven changed files. No remaining overclaims on hook coverage, shell write protection, or provider qualification.
Validation record: Honest. The validation doc names what was tested, what it proves, and what it does not prove.
Operator read-through and no-merge hold remain in force. This review satisfies the configured Claude slot requirement at the reviewed head. No merge authority is conferred; that remains with Gate under a live operator grant after the operator reads the guide.
|
Required review completed at 4350bbe: Claude review, successful configured workflow. This is actual provider review evidence, not a substituted local review or a waiver. It joins the earlier independent exact-head review and passing CI/CLI validation. Consolidation: no actionable defects. Claude's three nonblocking observations are accepted without another edit: the mail example already labels its concrete names as placeholders and instructs real replies to use The configured review ran under existing account/settings after the coordinator clarified ordinary review requests were authorized. No purchase or limit increase occurred. The earlier missing-review prerequisite is resolved; no head change or repeated broad review is needed. Remaining: release the explicit operator read-through hold after reading Fleet 101 at this head, and supply an operator-minted live Gate grant. The T0 scoped mint request is in the merge-preparation comment. Gate itself has not evaluated this head, so this consolidation is evidence, not a Gate pass or merge authority. #335 is the sole teaching change to land; #329 stays open as superseded review history until #335 lands. |
|
Grant-inventory refresh supersedes the earlier expired-grant blocker and mint request. Supported discovery was rerun with
#335 remains at No new grant is requested. Reuse the existing T0 grant after refreshing its validity at execution time. The explicit operator read-through hold remains the only current operator decision for this teaching task. Required Claude review, independent review and CI evidence are already complete. No Gate evaluation or merge was performed while that hold remains. |
|
The operator has now explicitly released the read-through hold for #335 and authorized landing through Gate using the existing grant. Earlier hold statements are superseded. Exact head remains 4350bbe with completed independent and configured Claude reviews and green CI. Gate run run_82fd6109114d8ce5 parked on review-evidence recognition; proceeding through its normal judgment path, without waiving or fabricating review evidence. After verified landing, close superseded #329 unmerged. No installation authorized. |
Fleet 101 previously asked newcomers to read a 1,331-line runtime investigation before using Fleet. This follow-up makes Workbench 101 the entry page and reading map, with a focused Fleet chapter that follows one assignment through a question, handoff and exact-head evidence. The detailed material from #329 remains available as a dated runtime/model reference.
The reader follows Workbench → Fleet 101 → installation/run guide. Linked onboarding, overview and README text now use optional roles and direct peer questions, distinguish receipts from observed activity, and state the actual hook-admission boundary. A real CLI walkthrough exposed the missing requirement to create/fetch a branch before dispatch; both command paths now include it.
This is the operator-requested teaching follow-up to #329, reconciling both independent SIMPLIFY reviews. It supersedes the proposed first-reader structure there; #329 remains open and held. Its exhausted three-cycle panel is not restarted or bypassed by another bot request. Runtime repairs stay with their existing owner.
Validation: Fleet/Org tests and both Claude/Codex adapter suites passed; the full example passed against a fresh binary in disposable state with synthetic hook events. That walkthrough is CLI evidence, not a learner trial or real provider workflow. The separately observed live Codex holder/contender apply_patch result is documented narrowly. See
cmd/fleet/docs/fleet-teaching-validation.mdfor review dispositions, evidence boundaries and residuals. Independent final review passed exact head4350bbedf13f2b383c651c9949359a1cb50f4d78with no remaining actionable documentation findings: #335 (comment). The first review caught a receipt-kind mismatch; the corrected walkthrough now asserts that the actual assigned work row reaches done.HOLD: operator read required. No Gate call, merge, deployment or live installation authorized by this PR. Known starting-state recovery, arbitrary shell-write coverage, surviving effects and Windows qualification are not represented as solved by documentation.