Skip to content

Add null guard in iframely-link #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siniakinaa merged 2 commits into from
Jun 25, 2026
+1 −1
Merged

Add null guard in iframely-link #676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3749fd
Add null guard in iframely-link
siniakinaa Jun 25, 2026
b213f62
fix after review
siniakinaa Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/links/iframely-link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default {

const value = typeof(v) === 'string' ? {href: v} : v; // If link has no `media` and no `type` attributes, HTMLMetaHandler assigns the value=href;

if (value.href) { // else it's not a link, it is Iframely-optimized meta fields ("iframely:title", etc.)
if (value?.href) { // else it's not a link, it is Iframely-optimized meta fields ("iframely:title", etc.)
let wlr = whitelistRecord;
if (whitelistRecord.isDefault
&& !Array.isArray(value) && value.href && /^(?:https?:)?\/\//.test(value.href)
Expand Down
Loading