Skip to content

Validators: allow https: as allow-all * value in CSP frame-ancestors check #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iparamonau merged 2 commits into from
Jun 25, 2026
Merged

Validators: allow https: as allow-all * value in CSP frame-ancestors check #677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0470ec
fix: treat CSP frame-ancestors scheme-source (https:) as permissive
siniakinaa Jun 25, 2026
19c409d
change comment
siniakinaa Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/plugins/validators/async/21_checkContentType.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ export default {

if (frame_ancestors) { // allow only if it contains " * " or "http://*" or "https://*"
frame_ancestors = frame_ancestors.replace(/https?:\/\/\*/ig, '*'); // Ex. Behance video streams via Adobe CDN
frame_ancestors = frame_ancestors.replace(/\bhttps?:(?!\S)/ig, '*'); // Ex. "frame-ancestors https:" - scheme-only means any HTTPS origin
frame_ancestors = frame_ancestors.replace(/^\*/i, ' *');
frame_ancestors = frame_ancestors.replace(/\*$/i, '* ');
if (frame_ancestors.indexOf(' * ') == -1) {
Expand Down
Loading