fix(screenote): group viewport uploads into one version - #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenote reviews now keep desktop, tablet, and mobile captures behind one viewport switcher instead of publishing three separate versions that all appear as desktop. Existing PNG/JPEG uploads use the same manifest-backed path without reintroducing browser startup, so they retain viewport grouping too.
The workflow builds one private, resumable manifest per capture set and publishes it once through the pinned
snapshot --manifestCLI contract. It validates provenance, file containment, modes, grouping keys, JSON Lines completion, and the final review URL before cleanup. Timeouts and partial failures retain the unchanged private directory for a safe retry, while the legacyscreenshot createtuple remains allowlisted for compatibility.The protected integration job now exercises both the new manifest path and the legacy upload path against the recorded public CLI baseline.
Validation
python3 -m unittest discover -s tests(78 tests)plugins/screenote/evals/lint-skills.shpython3 scripts/generate-agent-packages.py --checkactionlint .github/workflows/agent-platforms.ymlplugins/screenote/scripts/screenote-cli.sh --check-contractagainst Screenote CLI PR 6