Skip to content

changedate + add VEP_UCD#50

Open
loumir wants to merge 9 commits into
ivoa:mainfrom
loumir:loumir-docdate-update-vep-addition
Open

changedate + add VEP_UCD#50
loumir wants to merge 9 commits into
ivoa:mainfrom
loumir:loumir-docdate-update-vep-addition

Conversation

@loumir
Copy link
Copy Markdown
Contributor

@loumir loumir commented Apr 27, 2026

  • changed the document date to today
  • added VEP_UCD to read and improve if necessary
  • need to review VEP for obs.event --> definition, used-in , etc.

Copy link
Copy Markdown
Contributor Author

@loumir loumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this uploads the VEP-UCD so that they can be reviewed by all authors and improved .

Copy link
Copy Markdown
Collaborator

@bkhelifi bkhelifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, @loumir . I have few comments

Comment thread VEPforUCD/VEP-UCD-30-stat-error-sup-inf.txt Outdated
Section 5.4. Excess rms-flux correlation

Discussion: TBD in semantics & HEIG
Propose stat.error.below instead of stat.error.negative ( Mireille)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below is not really from a quantitative sematics, more a geographic one...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find stat.error.negative ambiguous. is it understandable in every context ? a discussion with inputs from semantics is probably needed.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find stat.error.negative ambiguous. is it understandable in every context ? a discussion with inputs from semantics is probably needed.

I think stat.error.negative/stat.error.positive are less ambiguous than (for example) stat.error.lower/stat.error.upper, stat.error.inf/stat.error.sup, or stat.error.below/stat.error.above. Negative/positive I think is fairly clear in the sense that the quantity with negative/positive error is always numerically lower than/higher than the actual quoted value.

For lower/upper, inf/sup, below/above etc. it's easy to get into trouble with quantities for which the more significant value is more negative, for example, a surface brightness of xxx mag/square degree. Does the stat.error.above value mean a larger surface brightness (smaller magnitude) or a larger magnitude (lower surface brightness)? I've seen both definitions used many times and would prefer a term that ideally eliminates this ambiguity.

Comment thread VEPforUCD/VEP-UCD-31-obs-event.txt Outdated
Comment thread VEPforUCD/VEP-UCD-31-obs-event.txt Outdated

- name: Build the document
run: make biblio ${{ env.doc_name }}-draft.pdf
run: make ${{ env.doc_name }}-draft.pdf
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing the bibliography??

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how this happened.
The workflow has been changed .
I agree we must have the bibliography .

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fixed now in the updated version of preview.yml

Rationale:

Discussion: suffix E exists and allows various combinations already.
Harmonize with UCDList1.6 definition
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proposes an amendement of the current definition, adding simplicity and the dimension.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok if the additional dimension property is adopted as a new feature in the UCDs .
E means Q already + belonging to the category of spectral data

Used_in: ??????
Rationale:

Discussion: can we use instead "phys.fluence;phys.count;em.energy"? never clear whether we multiply by em.energy or divide...
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no because adding "em.energy" does not mean "division per energy"! This proposal is ambiguous in term of dimension, which is not the scope of this VEP.

Comment thread VEPforUCD/VEP-UCD-28-ParticleFluxes.txt Outdated
Comment thread VEPforUCD/VEP-UCD-28-ParticleFluxes.txt Outdated
Used_in:

Rationale:
Discussion: defined in UCDList1.6 with suffix E already allowing pre/post combinations
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proposal is an amendement, precising the dimension

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

loumir and others added 5 commits May 4, 2026 19:13
Co-authored-by: Bruno Khélifi <khelifi@in2p3.fr>
Co-authored-by: Bruno Khélifi <khelifi@in2p3.fr>
Co-authored-by: Bruno Khélifi <khelifi@in2p3.fr>
Co-authored-by: Bruno Khélifi <khelifi@in2p3.fr>
Co-authored-by: Bruno Khélifi <khelifi@in2p3.fr>
@loumir loumir requested a review from bkhelifi May 4, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants