Skip to content

Update GLTypeInfo.hpp - #2

Open
annehe9 wants to merge 1 commit into
ixchow:masterfrom
annehe9:patch-2
Open

Update GLTypeInfo.hpp#2
annehe9 wants to merge 1 commit into
ixchow:masterfrom
annehe9:patch-2

Conversation

@annehe9

@annehe9 annehe9 commented Aug 14, 2019

Copy link
Copy Markdown
Contributor

added mat3 to TypeInfo, since hack-mesh-align uses mat3

added mat3 to TypeInfo, since hack-mesh-align uses mat3
@ixchow

ixchow commented Aug 28, 2019

Copy link
Copy Markdown
Owner

I am slightly nervous about this change interacting badly with attribute setting code; I believe one needs to call glAttribPointer() three times for a in mat3 attribute since it ends up bound to three (subsequent) attribute locations. However, if I recall, the way GLTypeInfo gets used in the kit code would result in only one glAttribPointer() call.

I will need to look into this further before accepting the push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants