Skip to content

Fix Julia additional dependency specifiers - #2703

Merged
j178 merged 1 commit into
masterfrom
julia-deps
Sep 9, 2026
Merged

Fix Julia additional dependency specifiers#2703
j178 merged 1 commit into
masterfrom
julia-deps

Conversation

@j178

@j178 j178 commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Closes #2700

Copilot AI lite review requested due to automatic review settings September 9, 2026 00:40
@j178 j178 added the bug Something isn't working label Sep 9, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-09T00:44:02.820913Z bdc1a91 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI reviewed Sep 9, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is narrowly scoped, aligns behavior with pre-commit, and includes a targeted regression test plus documentation updates.

Pull request overview

Fixes Julia hook additional_dependencies handling so that version/UUID specifiers (for example Runic@1.10.0, TOML=<uuid>) work, matching pre-commit’s behavior and resolving #2700.

Changes:

  • Switch Julia environment installation to route additional_dependencies through Pkg’s REPL add parser (Pkg.REPLMode.pkgstr) instead of Pkg.add(::Vector{String}).
  • Add a regression test covering Name@version and Name=uuid specifiers.
  • Update language documentation to describe the supported Julia dependency syntax.
File summaries
File Description
docs/languages.md Documents that Julia additional_dependencies supports Pkg REPL add syntax including version specifiers.
crates/prek/tests/languages/julia.rs Adds coverage to ensure specifier-based dependencies install and are reflected in the active project.
crates/prek/src/languages/julia.rs Implements REPL-mode add handling for additional_dependencies during Julia env instantiation.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.10%. Comparing base (c0b9749) to head (bdc1a91).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2703   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files         141      141           
  Lines       30066    30066           
=======================================
  Hits        28293    28293           
  Misses       1773     1773

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@prek-ci-bot

prek-ci-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

📦 Cargo Bloat Comparison

.text size change: +0.00% (12.8 MiB → 12.8 MiB)

Expand for cargo-bloat output

Head Branch Results

File  .text     Size             Crate Name
0.1%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_44_0_aes_gcm_encrypt_avx512
0.1%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_44_0_aes_gcm_decrypt_avx512
0.0%   0.7%  96.5KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
0.0%   0.4%  50.1KiB              prek <<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.4%  49.7KiB              prek prek::run::{closure#0}
0.0%   0.4%  48.7KiB annotate_snippets annotate_snippets::renderer::render::render
0.0%   0.3%  43.9KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.3%  40.4KiB              prek prek::cli::run::run::run::{closure#0}
0.0%   0.3%  40.3KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
0.0%   0.3%  32.7KiB              prek <prek::languages::rust::rust::Rust as prek::languages::LanguageBackend>::install::{closure#0}
0.0%   0.2%  28.7KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  28.2KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  28.2KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_44_0_edwards25519_scalarmuldouble_alt
0.0%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_44_0_edwards25519_scalarmuldouble
0.0%   0.2%  27.3KiB              toml <toml::de::deserializer::value::ValueDeserializer as serde_core::de::Deserializer>::deserialize_any::<<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor>
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
4.2%  86.9%  11.1MiB                   And 20372 smaller methods. Use -n N to show more.
4.8% 100.0%  12.8MiB                   .text section size, the file size is 263.7MiB

Base Branch Results

File  .text     Size             Crate Name
0.1%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_44_0_aes_gcm_encrypt_avx512
0.1%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_44_0_aes_gcm_decrypt_avx512
0.0%   0.7%  96.5KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
0.0%   0.4%  50.1KiB              prek <<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.4%  49.7KiB              prek prek::run::{closure#0}
0.0%   0.4%  48.7KiB annotate_snippets annotate_snippets::renderer::render::render
0.0%   0.3%  43.9KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.3%  40.4KiB              prek prek::cli::run::run::run::{closure#0}
0.0%   0.3%  40.3KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
0.0%   0.3%  32.7KiB              prek <prek::languages::rust::rust::Rust as prek::languages::LanguageBackend>::install::{closure#0}
0.0%   0.2%  28.7KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  28.2KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  28.2KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_44_0_edwards25519_scalarmuldouble_alt
0.0%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_44_0_edwards25519_scalarmuldouble
0.0%   0.2%  27.3KiB              toml <toml::de::deserializer::value::ValueDeserializer as serde_core::de::Deserializer>::deserialize_any::<<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor>
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
4.2%  86.9%  11.1MiB                   And 20372 smaller methods. Use -n N to show more.
4.8% 100.0%  12.8MiB                   .text section size, the file size is 263.7MiB

@prek-ci-bot

prek-ci-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment
  • OS: Linux 6.17.0-1022-azure
  • CPU: 4 cores
  • prek version: prek 0.5.2+15 (4fb4546 2026-09-09)
  • Rust version: rustc 1.98.1 (48a229cea 2026-09-01)
  • Hyperfine version: hyperfine 1.20.0
CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base --version 2.2 ± 0.1 2.1 3.1 1.02 ± 0.08
prek-head --version 2.2 ± 0.1 2.0 2.5 1.00

prek list

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base list 9.2 ± 0.6 8.8 12.8 1.01 ± 0.07
prek-head list 9.1 ± 0.2 8.7 9.9 1.00

prek validate-config .pre-commit-config.yaml

⏭️ Skipped: .pre-commit-config.yaml not found

prek sample-config

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base sample-config 2.4 ± 0.1 2.3 2.6 1.00
prek-head sample-config 2.4 ± 0.2 2.3 3.8 1.00 ± 0.09
Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 38.4 ± 1.3 36.8 41.3 1.00
prek-head run --all-files 38.7 ± 0.8 37.7 40.2 1.01 ± 0.04

prek run --all-files (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 39.0 ± 2.2 37.2 47.5 1.02 ± 0.06
prek-head run --all-files 38.4 ± 1.0 35.8 40.1 1.00
Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 38.6 ± 1.2 36.1 40.8 1.00
prek-head run --all-files 38.8 ± 1.0 36.3 41.4 1.01 ± 0.04
Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run trailing-whitespace --all-files 12.9 ± 0.4 12.2 13.9 1.00
prek-head run trailing-whitespace --all-files 13.7 ± 0.4 12.8 14.5 1.06 ± 0.05

prek run end-of-file-fixer --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run end-of-file-fixer --all-files 11.5 ± 0.5 10.6 12.4 1.00 ± 0.06
prek-head run end-of-file-fixer --all-files 11.4 ± 0.5 10.5 12.4 1.00

prek run check-json --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-json --all-files 7.9 ± 0.3 7.5 8.4 1.01 ± 0.05
prek-head run check-json --all-files 7.8 ± 0.3 7.4 8.3 1.00

prek run check-yaml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-yaml --all-files 7.6 ± 0.1 7.3 7.8 1.00
prek-head run check-yaml --all-files 7.7 ± 0.1 7.4 8.0 1.02 ± 0.02

prek run check-toml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-toml --all-files 8.1 ± 0.3 7.6 8.8 1.02 ± 0.05
prek-head run check-toml --all-files 7.9 ± 0.2 7.5 8.2 1.00

prek run check-xml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-xml --all-files 7.9 ± 0.5 7.3 9.2 1.05 ± 0.08
prek-head run check-xml --all-files 7.6 ± 0.3 7.1 8.5 1.00

prek run detect-private-key --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run detect-private-key --all-files 11.0 ± 0.8 9.9 13.0 1.01 ± 0.08
prek-head run detect-private-key --all-files 10.8 ± 0.5 10.1 12.0 1.00

prek run fix-byte-order-marker --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run fix-byte-order-marker --all-files 13.5 ± 0.9 11.6 14.9 1.05 ± 0.09
prek-head run fix-byte-order-marker --all-files 12.9 ± 0.7 11.8 14.1 1.00
Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.4 ± 0.1 4.4 4.6 1.01 ± 0.02
prek-head install-hooks 4.4 ± 0.0 4.3 4.4 1.00

prek install-hooks (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.3 ± 0.1 4.2 4.4 1.00
prek-head install-hooks 4.3 ± 0.1 4.3 4.4 1.00 ± 0.02
File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run 23.7 ± 0.4 23.2 24.9 1.00 ± 0.02
prek-head run 23.7 ± 0.4 23.1 24.6 1.00

prek run --files '*.json' (specific file type)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --files '*.json' 5.1 ± 0.1 5.0 5.2 1.02 ± 0.02
prek-head run --files '*.json' 5.0 ± 0.0 4.9 5.0 1.00
Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --dry-run --all-files 6.7 ± 0.1 6.6 7.0 1.00
prek-head run --dry-run --all-files 6.8 ± 0.2 6.5 7.3 1.01 ± 0.03
Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-hooks-apply --all-files 7.9 ± 0.0 7.8 7.9 1.00
prek-head run check-hooks-apply --all-files 8.0 ± 0.1 7.8 8.2 1.01 ± 0.01

prek run check-useless-excludes --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-useless-excludes --all-files 8.0 ± 0.1 7.9 8.4 1.00
prek-head run check-useless-excludes --all-files 8.1 ± 0.3 7.9 9.0 1.01 ± 0.04

prek run identity --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run identity --all-files 7.0 ± 0.0 6.9 7.0 1.00
prek-head run identity --all-files 7.0 ± 0.1 6.9 7.3 1.00 ± 0.02

@j178
j178 merged commit 156c0ce into master Sep 9, 2026
38 checks passed
@j178
j178 deleted the julia-deps branch September 9, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Julia additional_dependencies fails for Name@version syntax

2 participants

@j178