test: migrate behavioral tests and enforce 90% branch coverage - #296
Merged
Merged
Conversation
Migrate the remaining 83 legacy Node test files, remove method-replacement and fixed-wait allowances, and replace runtime source checks with observed behavior. Preserve fixes exposed by the new entrypoint regressions. Validate all 2,078 Node tests and 364 offline Chromium scenarios. Enforce 90% branch coverage across all 82 production files and each critical module; the final retained-evidence lower bound is 9,179/10,184 branches (90.13%).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace legacy source-text regressions, method replacements, and fixed waits with executable behavior tests, and enforce the policy across the repository. The default complete coverage run now requires at least 90% branch coverage across all production sources and separately in each of seven critical orderbook modules.
Changes
Local validation
Verified with Node 24.16.0:
The coverage percentage is a retained-evidence lower bound. No skipped or retried scenarios were accepted, and all 82 reported source hashes matched the workspace after collection.
Migration map · Coverage contract and measurements
All account, order, and media operations in these tests use offline fixtures. Live Binance, Tampermonkey installation, and media-site acceptance have not been performed.