Updates - #2
Merged
Merged
Conversation
✅ Deploy Preview for sorting-viewer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Modernizes
sorting-viewerto a healthy, maintainable state: every dependencyupdated to its latest supported major, a full linting/formatting/testing/CI
setup, and a PrimeVue 3 → 4 theming rewrite. Bumps the app to
1.0.0.Each commit is self-contained and passes the full local gate
(
lint→format:check→type-check→test:run→build).Highlights
Build stack
@vitejs/plugin-vue→ 6,vue-tsc→ 3,@vue/tsconfig→ 0.9,@types/node→ 24,primeicons→ 8.npm-run-allwithnpm-run-all2and removed theunused
@vitejs/plugin-vue-jsx.rewrite is not yet supported by
typescript-eslintorvue-tsc.PrimeVue 3 → 4 (the centerpiece)
.darkclass toggle viadarkModeSelector, replacing theold
document.styleSheetsmutation hack (src/utils/helpers.ts, deleted).Dropdowncomponent toSelect(v4 rename).--p-*) names.Tooling & tests
.prettierignore.@vue/test-utils+ jsdom: unit tests for all six sort algorithmsplus an app-mount smoke test (7 tests).
build on every PR and on pushes to
main.netlify.tomlpinning the production build to Node 24 (required by Vite 8).Defaults & fixes
var(--yellow-300value(missing closing paren) meant the "smallest value" highlight never rendered.
COLORS_DARK,THEMES.file).Verification
npm ci.Aura, the light/dark toggle flips the whole UI (Select, Dialog, Toast,
Slider, Buttons, background), all six algorithms select and sort to
completion, and the info Dialog and Toast work — with zero console errors.
See
CHANGELOG.mdfor the full list.