Remove the @Source provenance annotations - #5
Open
jamiewest wants to merge 1 commit into
Open
Conversation
Abandons the annotation-based upstream-provenance feature: every ported type carried a @source(...) block naming its C# file, namespace, repo, and path. Nothing consumed them — no test, tool, or doc build reads the annotation — and the drift audit maps Dart types to upstream by filename and declaration, not by annotation, so they were 1,800 lines of maintenance surface with no reader. Removes all 215 annotations across 212 files, their annotations.dart imports (211 package imports plus one relative import in auto_chat_tool_mode.dart), and the lib/annotations.dart library itself. Removing a public library is breaking; recorded in the changelog under the pending 0.8.0 entry. Both packages analyze clean, format clean by exit code, 1,029 + 47 tests pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abandons the annotation-based upstream-provenance feature. Every ported type carried a
@Source(...)block naming its C# file, namespace, repository, and path — 215 annotations across 212 files, ~1,800 lines.Why remove: nothing consumes them. No test, tool, or doc build reads the annotation, and the drift audit maps Dart types to upstream by filename and declaration, not by annotation. They were pure maintenance surface: every new port had to hand-write one, and nothing noticed when they went stale.
What's removed:
@Source(...)blocks (pure deletion — the diff is 1,801 deletions, 0 insertions before the changelog note)package:imports plus one relative import the analyzer caught)lib/annotations.dartitself — it contained only theSourceclassRemoving a public library is breaking; recorded in the changelog under the pending 0.8.0 entry alongside the other breaks from #4.
Verification: both packages
dart analyzeclean,dart format --set-exit-if-changedclean (checked by exit code), 1,029 + 47 tests pass.🤖 Generated with Claude Code