Find Python portably so the board tools work on Windows - #3
Open
zxwolfpirexz wants to merge 1 commit into
Open
Conversation
bin/board-state.sh calls python3 twice. Windows has no python3 — the python.org installer provides py and python — so the script fails at line 29 with "python3: command not found" even when the server is healthy. bin/board.sh has the same call and is currently masked: its fallback (|| echo 8794) happens to match the default port, so it appears to work while silently ignoring a configured port. That is the quieter of the two faults. This matters beyond the scripts: the CLAUDE.md block the installer appends tells the agent to run board-state.sh before commenting on the board, so on Windows that instruction could not be followed at all. Probe once for python3, then python, then py. python3 is tried first, so macOS and Linux resolve exactly as before. Fixes jaredrhod#2 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2.
bin/board-state.shcallspython3twice. Windows has nopython3— the python.org installer providespyandpython— so the script dies at line 29 withpython3: command not foundeven when the server is healthy.bin/board.shhas the same call and is currently masked: its|| echo 8794fallback happens to match the default port, so it looks fine while silently ignoring a configuredport. That is the quieter of the two faults and the reason this went unnoticed.This matters beyond the two scripts. The CLAUDE.md block the installer appends tells the agent to run
board-state.shbefore commenting on the board, so that it reads the real scene rather than trusting memory. On Windows that instruction could not be followed at all.The change: probe once for
python3, thenpython, thenpy.python3is tried first, so macOS and Linux resolve exactly as before — no behaviour change on either.Verified on Windows 11 / Git Bash / Python 3.14.7:
and the correct failure path when the server is stopped:
Everything else on Windows checked out end to end once patched: camera and hand tracking live,
presentmoving the ring center-stage, and the ring reflecting agent state written tobarehands/state/state.