update.bat: resolve the real Desktop for the icon tip (OneDrive redirect) - #3
Open
BigBeedle wants to merge 1 commit into
Open
update.bat: resolve the real Desktop for the icon tip (OneDrive redirect)#3BigBeedle wants to merge 1 commit into
BigBeedle wants to merge 1 commit into
Conversation
…ect)
The "want a desktop Update icon?" tip checked %USERPROFILE%\Desktop, which
misses machines where OneDrive redirects the Desktop (the icon exists at
%USERPROFILE%\OneDrive\Desktop, so the tip fires even though the user is
running it from that very icon). Resolve the actual Desktop folder via
[Environment]::GetFolderPath('Desktop') and fall back to the classic path
if the query fails.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
On Windows machines where OneDrive redirects the Desktop (very common on Windows 11 — the Desktop lives at
%USERPROFILE%\OneDrive\Desktop), the end-of-update tipfires even when the user is running the update from that very icon, because the check hardcodes
%USERPROFILE%\Desktop.The fix
Resolve the actual Desktop folder with
[Environment]::GetFolderPath('Desktop')(which follows the OneDrive/Known Folder redirection), and fall back to the classic%USERPROFILE%\Desktopif the PowerShell query fails for any reason. No behavior change on non-redirected machines.Tested on Windows 11 with a OneDrive-redirected Desktop and an
Update <name>.baticon present: full update run of all five repos, tip correctly suppressed.🤖 Generated with Claude Code