fix: enforce strategy slippage bounds, precise fee math, and vault reentrancy guard#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slither-MCP-driven hardening pass. Fixes the four substantive findings (the rest of the detector output was triaged as false positives — trusted-protocol balance-delta reentrancy, zero-guard strict-equality, accumulator uninitialized-locals — and intentionally left).
Fixes
PendlePtStrategyFacet): added a configurablemaxSlippageBps(default 1%) + owner setterpendleSetSlippage.pendleDeposit/pendleWithdrawnow derive a realminPtOut/minTokenOutfrom the oracle mark so the router enforces the bound, and use the router'snetPtOut/netTokenOutreturns instead of stale balance deltas. Falls back to prior behaviour only when no oracle is configured (unpriced markets).Vault._accrueFees): performance-fee math rewritten withMath.mulDiv, eliminating the divide-before-multiply rounding.Vault): added OZReentrancyGuard;_deposit/_withdraware nownonReentrant. Standard guard (OZ 5.0.2 has no transient variant); safe because the ERC-4626 surface is the non-upgradeable native contract and facets use namespaced storage.MorphoStrategyFacet): capturewithdraw's returned shares and bound againstpreviewWithdraw, mirroring the existingmorphoDepositslippage check.Tests
pendleSetSlippagegating; wired the new selector into the test diamond cut.totalAssetstests reordered to set the oracle after the seed buy — the new guard correctly rejects buying PT at par against a discounted mark.Verification
forge buildclean;forge fmtclean.forge test --no-match-path 'test/integration/*'→ 128 passed, 0 failed.diamond-detect→ no storage collisions, 8 namespaced regions each on its own slot.