Align RSS feed cards with shared Phosphor glow-border styling#54
Merged
jaypatrick merged 5 commits intomainfrom May 7, 2026
Merged
Align RSS feed cards with shared Phosphor glow-border styling#54jaypatrick merged 5 commits intomainfrom
jaypatrick merged 5 commits intomainfrom
Conversation
Agent-Logs-Url: https://github.com/jaypatrick/jk.com/sessions/7d38850d-c3e2-4d0b-9470-425cea4d8716 Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jaypatrick/jk.com/sessions/7d38850d-c3e2-4d0b-9470-425cea4d8716 Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jaypatrick/jk.com/sessions/7d38850d-c3e2-4d0b-9470-425cea4d8716 Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix RssFeed card shimmer and border to match Portfolio cards
Align RSS feed cards with shared Phosphor glow-border styling
May 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the “Latest Thoughts” RSS feed cards with the shared Phosphor card styling contract used elsewhere (notably Portfolio cards), by switching them to the shared glow-border iridescent utility treatment and removing bespoke border/glow overrides.
Changes:
- Add
glow-borderto RSS feed card markup so global Phosphor utilities own the border/glow styling. - Remove local
.feed-cardborder/shadow and hover border/shadow overrides, keeping only layout/transform behavior. - Update the RssFeed source test to assert the new class composition and the slimmed-down
.feed-cardstyling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/sections/RssFeed.svelte | Applies shared glow-border iridescent styling to feed cards and removes local border/shadow overrides. |
| src/components/sections/RssFeed.test.ts | Updates tests to assert the new shared class contract and reduced local .feed-card CSS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Latest Thoughtscards were using bespoke border/glow styling that diverged from the shared Phosphor treatment used by the Portfolio case study cards. This change switches the RSS cards onto the sameglow-border iridescentstyling contract and removes the local overrides that were muting the effect.Shared Phosphor card treatment
glow-borderto RSS feed cards so they use the same shimmer/border/glow stack as Portfolio cardsRemove local style overrides
border,box-shadow, and hover border/shadow rules from.feed-cardoverflowandtransformtransition/hover liftTighten the component contract
.feed-cardblock now only contains the remaining layout/transform rulesOriginal prompt
Four polish fixes for the Phosphor design system
Fix 1 — RssFeed "Latest Thoughts" card shimmer/border should match Portfolio "Work That Ships" cards exactly
File:
src/components/sections/RssFeed.svelteThe
feed-cardclass has its own hand-rolled border, box-shadow, and hover styles that don't match the Phosphor.glow-border.iridescenttreatment used on the Portfolio case study cards. The feed cards already haveclass="feed-card iridescent rounded-xl p-6 flex flex-col"— they use.iridescent— but.feed-cardoverrides the border and shadow with custom values that are weaker/different.Changes:
.feed-cardtheborder,box-shadowand hoverborder-color/box-shadowrules — let.glow-borderand.iridescentfromglobal.csshandle those (exactly as Portfolio cards do). Keep only thetransition,overflow: hidden, andtransformrules in.feed-card.glow-borderto the article's class list alongsideiridescent:.feed-card:hover— keep onlytransform: translateY(-3px).The goal: feed cards should be visually identical to Portfolio case study cards in their border, glow, and shimmer treatment.
Fix 2 — Delete redundant contact info block from
Contact.svelteFile:
src/components/sections/Contact.svelteFind and delete the entire "Contact details" block containing the phone number and location. This is the
<div class="space-y-6 mb-6">block that contains:<a href="tel:+19807297877">phone link with the TEL label and "980.729.7877" text<div class="flex items-center gap-4">with the LOC label and "Charlotte, North Carolina" textDelete both
<a>and<div>elements and their full contents inside thatspace-y-6wrapper. Also delete the wrapper<div class="space-y-6 mb-6">itself since it will be empty.Do not touch anything else — the Quick Start cards, the heading, the form, or the Calendly button remain untouched.
Fix 3 — Portfolio case study card label chips: apply full Phosphor bracket-tag chip treatment including iridescent shimmer
File:
src/components/sections/Portfolio.svelteThe label chip in the top-left of each case study card (e.g. "Azure Migration", "Zero Trust") currently uses the base
.chipclass with a plain blue border/color:Replace with a Phosphor bracket-tag chip that:
[ LABEL ]bracket wrapping with the same bracket style as the Hero role chipsiridescentshimmer (matching the card's own shimmer treatment)--color-primary) to visually match the hero chipsReplace the
<span class="chip" ...>with:Add to
<style>inPortfolio.svelte:This gives the label chips the same
[ TAG ]bracket treatment and iridescent shimmer as the Hero role tags, making them consistent across the site.Fix 4 — Footer top spacing: add padding-top so content doesn't sit flush against the border
File:
src/components/layout/Footer.svelteThe
<div class="section-container py-12">already haspy-12but the content is still sitting nearly flush against the topborder-top: 1px solid var(--color-border)of the footer element.The issue is the footer
<footer>element itself has no top padding, andsection-containerwithpy-12should be sufficient — but check if there's something compressing it.Change
py-12topt-16 pb-12on the<div class="section-container py-12">:This adds a clear breathing gap between the footer border line and the first row of content (the Brand / Navigation / Connect columns).
Files changed
src/components/sections/RssFeed.svelteglow-borderc...This pull request was created from Copilot chat.