Doxygen generated file#345
Conversation
|
Can you squash these commits and rebase? |
|
Sure thing! Do you see any changes that needs to be made first? On November 27, 2015, at 12:12 PM, Jesse Beder notifications@github.com wrote: Can you squash these commits and rebase? — |
|
Alrighty! I made a few more changes and have squashed and rebased. |
|
Err there are still three commits showing up for me. Could you squash them into a single commit and then |
|
Oh dear. I know what happened. I debased against the wrong branch. I'll fix it. |
* Doxyfile is generated using cmake
* doxygen support option (USE_DOXYGEN) added
* doxygen is generated through `make doc`
* doxygen is installed when using `make install`
* Updated README to work with doxygen and to document UI with cmake
and doxygen
|
Ok. It should be fixed! |
|
OK, I finally got a chance to try this out (sorry about the delay). I think this is a good change overall, but a couple questions:
Can you make this just a warning, not an error? It's nice, e.g., that if you don't have doxygen installed, it just says and then keeps on going.
|
Should I make an effort to have it automatically generate the doxygen if it's installed when |
|
Did you want all of the test code excluded from doxygen or just the source code in |
Yes, that would be nice.
Just the gtest/gmock code. |
|
@jbeder FYI, you could use CodeDocs.xyz (disclaimer, I am the creater). It will generate the doxygen docs and host them. It will rerun every push, similar to to Travis-ci. I enabled it for my fork of yaml-cpp, and you can see the generated doxygen docs here. All you need are these changes, and login to CodeDocs.xyz to enable the service. I can create a PR if you want. |
|
@paulnovo that's pretty sweet. Happy to accept a PR. Two questions about the service:
|
|
@jbeder ok, I created PR #375. To answer your questions:
INPUT = . Then in your .codedocs file just put this: DOXYFILE = [relative location of Doxygen config file] Then you could run Doxygen on your Doxygen config file, and it should give similar output as CodeDocs. This isn't great, and needs to be improved. For this, or any other suggestions, please add an issue here. |
|
@paulnovo Thanks, I filed a couple issues in CodeDocs for these. I'll leave this PR open in case @theNerd247 updates it, which would make it easy to run locally. |
* fixed bug mentioned in jbeder#345 about `make install` giving an error when `make doc` isn't called previously
|
@jbeder Fixed the bug about the installation. Sorry for the wait. Classes took most of my time this semester. Let me know if you want me to squash and rebase or fix anything else. |
|
Is this PR still necessary with #375 being merged in? |
|
@theNerd247 yes. The codedocs config is just for that site. This is perfect for those that don't like being connected to the internet 24/7. |
|
Makes sense. Not to sound impatient but is there a reason this hasn't been merged yet? |
|
Sorry, I haven't had time. Should get an opportunity within a few weeks. |
Added support for documentation generation using doxygen.
Should fix #155 (or at least add a bit of resolution).