refactor: 处理scss引入方式#3476
Open
xiaoyatong wants to merge 2 commits into
Open
Conversation
- Fix useCallback refs with unstable deps (props.leftAction/rightAction) that triggered setActionWidth on every render, causing an infinite loop - Add width equality check before updating state to break the cycle - Fix `opened` ref accessed without `.current` in both H5 and Taro versions Closes #3433 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Taro build script's PostCSS plugin only handled @import rules but the source scss files had already been migrated to @use syntax. This caused the output dist scss files to retain deprecated @import rules, triggering Dart Sass deprecation warnings for downstream consumers. Align the Taro build (buildCSS, buildHarmonyCSS) with the H5 build by handling both @import and @use at-rules and ensuring @use with 'as *' in the output. Also fix sass compilation to place @use statements before variable definitions as required by the Sass spec. Closes #3430 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
action:review
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
总览该 PR 将构建脚本中的 SCSS 改动详情构建脚本 SCSS
Swipe 组件触摸状态与宽度同步优化
预估审查工作量🎯 3 (中等) | ⏱️ ~25 分钟 可能相关的 PR
建议审查人
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (73.68%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## feat_v4.x #3476 +/- ##
============================================
Coverage ? 87.87%
============================================
Files ? 295
Lines ? 19747
Branches ? 3079
============================================
Hits ? 17352
Misses ? 2389
Partials ? 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
发布说明
Bug Fixes
Refactor