Skip to content

Avoid bundling jackson jars - #792

Merged
uhafner merged 1 commit into
jenkinsci:mainfrom
apuig:strictBundled
Jul 31, 2026
Merged

Avoid bundling jackson jars#792
uhafner merged 1 commit into
jenkinsci:mainfrom
apuig:strictBundled

Conversation

@apuig

@apuig apuig commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

coverage-model pulls jackson-annotations, jackson-core, and jackson-databind as direct compile-scope deps, causing hpi to include it even when everything is already bundled by jackson3-api (an transitive jackson-annotations2-api)

Testing done

mvn clean verify
unzip -l plugin/target/coverage.hpi | grep "WEB-INF/lib"
        0  2026-07-30 18:20   WEB-INF/lib/
   281014  2026-07-30 18:20   WEB-INF/lib/coverage.jar
   171109  2026-06-19 10:23   WEB-INF/lib/coverage-model-0.71.1.jar

Also hpi:run with a Pipeline job using plugin/src/test/resources/io/jenkins/plugins/coverage/metrics/steps/jacoco.xml.

it rendered correctly Screenshot from 2026-07-30 16-50-04

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@github-actions
github-actions Bot requested a review from uhafner July 30, 2026 16:40
@github-actions

Copy link
Copy Markdown

☀️   Quality Monitor

Tests

   JUnit   Unit Tests: ✅ successful — 222 passed $\textsf{(±0)}$
   🚀   Integration Tests: ✅ successful — 157 passed $\textsf{(±0)}$, 7 skipped $\textsf{(±0)}$
   ⛔   Architecture Tests: ✅ successful — 15 passed $\textsf{(±0)}$

Coverage for New Code

   〰️   Line Coverage: 100.00% — perfect 🎉
   ➰   Branch Coverage: 100.00% — perfect 🎉

Coverage for Whole Project

   〰️   Line Coverage: 77.01% $\textsf{(±0)}$ — 714 missed lines
   ➰   Branch Coverage: 67.38% $\textsf{(±0)}$ — 288 missed branches

Style

   CheckStyle   CheckStyle: No warnings $\textsf{(±0)}$
   PMD   PMD: No warnings $\textsf{(±0)}$
   ☕   Java Compiler: No warnings $\textsf{(±0)}$

Bugs

   SpotBugs   SpotBugs: No bugs $\textsf{(±0)}$
   🐛   Error Prone: No bugs $\textsf{(±0)}$

Vulnerabilities

   🛡️   OWASP Dependency Check: 241 vulnerabilities $\color{green}{\textsf{(+241)}}$ — error: 17, high: 64, normal: 151, low: 9

Software Metrics

   🌀   Cyclomatic Complexity: 1040 (total)
   💭   Cognitive Complexity: 569 (total)
   ➿   N-Path Complexity: 1395 (total)
   📏   Lines of Code: 12192 (total)
   📝   Non Commenting Source Statements: 4108 (total)
   🔗   Class Cohesion: 100.00% (maximum)
   ⚖️   Weight of Class: 100.00% (maximum)

📌 Reference Results

Delta reports computed against the reference results of f8df161 in workflow run 30102342149.

🚦 Quality Gates

Overall Status: ✅ SUCCESS

✅ Passed Gates

  • ✅ Overall Tests Success Rate: 100.00 >= 100.00
  • ✅ Line Coverage in New Code: 100.00 >= 90.00
  • ✅ Branch Coverage in New Code: 100.00 >= 90.00
  • ✅ Potential Bugs in Whole Project: 0.00 <= 0.00
  • ✅ Style Violation in Whole Project: 0.00 <= 0.00

Created by Quality Monitor v4.15.0 (#82d77af). More details are shown in the GitHub Checks Result.

@uhafner uhafner added the dependencies Update of dependencies label Jul 31, 2026
@uhafner uhafner changed the title avoid bundling jackson jars Avoid bundling jackson jars Jul 31, 2026
@uhafner uhafner added the enhancement Enhancement of existing functionality label Jul 31, 2026

@uhafner uhafner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@uhafner
uhafner merged commit 42c5af9 into jenkinsci:main Jul 31, 2026
31 of 33 checks passed
@uhafner uhafner added bug Bugs or performance problems and removed enhancement Enhancement of existing functionality labels Jul 31, 2026
@apuig
apuig deleted the strictBundled branch July 31, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs or performance problems dependencies Update of dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants