Repository navigation
Make numpy an optional dependency - #48
Open
timminator wants to merge 1 commit into
Open
timminator wants to merge 1 commit into
timminator wants to merge 1 commit into
Conversation
Author
|
For the time being I made a fork with this PR in place - also with downloadable packages. People interested can find it here: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I am really liking your package and plan to use it in my project. :-)
It is already pretty lightweight but it would be awesome if it could work also without numpy.
It also doesn't really require it so I made it an optional dependency with this PR.
The old functionality is still kept out of the box, numpy is just lazily imported. This is similar to PyAV for handling its to_ndarray" function for example.
Let me know what you think or if you'd like any changes!