Skip to content

RTECO-1646 - Enhance Maven native mode support by adding server ID fl… #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fluxxBot wants to merge 8 commits into
base: master
Choose a base branch
from
+445 −7
Open

RTECO-1646 - Enhance Maven native mode support by adding server ID fl… #3637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d975608
RTECO-1646 - Enhance Maven native mode support by adding server ID fl…
fluxxBot Aug 3, 2026
939c6eb
RTECO-1646 - Update jfrog-cli-artifactory dependency to v0.8.1-0.2026…
fluxxBot Aug 3, 2026
b0021fe
Refactor test cases to remove unused projDir variable in Maven native…
fluxxBot Aug 3, 2026
b9cf4d7
RTECO-1646 - Enhance Maven native multi-module build test to resolve …
fluxxBot Aug 4, 2026
e64e8f1
RTECO-1646 - Refactor Maven test settings to resolve through test Art…
fluxxBot Aug 4, 2026
dc0cf86
RTECO-1646 - Refactor writeMavenDeploySettings to use test user/passw…
fluxxBot Aug 4, 2026
88ee614
RTECO-1646 - Update go.mod to replace jfrog-cli-artifactory and build…
fluxxBot Aug 4, 2026
41bdcc8
RTECO-1646 - Update go.mod and go.sum to use latest commit hashes for…
fluxxBot Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions buildtools/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,8 +711,16 @@ func runMvn(c *cli.Context, preferWrapper bool) (err error) {
if err != nil {
return err
}
// Maven does not accept --server-id; use the default configured server for usage reporting.
serverDetails, err := coreConfig.GetDefaultServerConf()
// Native accepts --server-id (for build-info collection: property tagging, virtual-repo
// resolution, repository lookups). Strip it from the goals and resolve the target server,
// falling back to the default configured server when not provided.
filteredMavenArgs, serverID, err := coreutils.ExtractServerIdFromCommand(filteredMavenArgs)

@agrasth agrasth Aug 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new behavior — strip --server-id from goals and resolve the target server — is scoped to the nativeMode && !configExists branch, but the flag is registered unconditionally for Mvn in commandsflags.go line 2148, so users on the legacy (config-file) path see --server-id in jf mvn --help and it silently has no effect.

Either error out when --server-id is passed in legacy mode, or make the serverIdMvn.Usage string (line 785 of commandsflags.go) explicitly note "no effect in legacy mode" so users aren't surprised.

if err != nil {
return fmt.Errorf("failed to extract server ID: %w", err)
}
// GetSpecificConfig with an empty serverID (defaultOrEmpty=true) returns the default server, so
// this covers both the --server-id and no-flag cases.
serverDetails, err := coreConfig.GetSpecificConfig(serverID, true, true)
if err != nil {
return err
}
Expand Down
4 changes: 4 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,3 +252,7 @@ require (
//replace github.com/jfrog/jfrog-client-go => github.com/jfrog/jfrog-client-go v1.54.2-0.20251007084958-5eeaa42c31a6

// replace github.com/jfrog/jfrog-cli-artifactory => github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260723100012-d9e9c3412cb2

replace github.com/jfrog/build-info-go => github.com/jfrog/build-info-go v1.13.1-0.20260804091857-2e9f7c89c1d5

replace github.com/jfrog/jfrog-cli-artifactory => github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260804092100-37b49cc418e4
8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,8 @@ github.com/jellydator/ttlcache/v3 v3.4.0 h1:YS4P125qQS0tNhtL6aeYkheEaB/m8HCqdMMP
github.com/jellydator/ttlcache/v3 v3.4.0/go.mod h1:Hw9EgjymziQD3yGsQdf1FqFdpp7YjFMd4Srg5EJlgD4=
github.com/jfrog/archiver/v3 v3.6.3 h1:hkAmPjBw393tPmQ07JknLNWFNZjXdy2xFEnOW9wwOxI=
github.com/jfrog/archiver/v3 v3.6.3/go.mod h1:5V9l+Fte30Y4qe9dUOAd3yNTf8lmtVNuhKNrvI8PMhg=
github.com/jfrog/build-info-go v1.13.1-0.20260728083052-16a97012811d h1:Yqbx+/9cIiZJmpyIkWDyC9Qjh4OaVeGWutADFaUzHr0=
github.com/jfrog/build-info-go v1.13.1-0.20260728083052-16a97012811d/go.mod h1:CYRUCvLKfyARjoJXLWAxce1qNUxTEtbRKAARkV42vpE=
github.com/jfrog/build-info-go v1.13.1-0.20260804091857-2e9f7c89c1d5 h1:CU8GecwasJYgdQa+bnSgOeKh2jmH4VNUwg2ch+fz3ao=
github.com/jfrog/build-info-go v1.13.1-0.20260804091857-2e9f7c89c1d5/go.mod h1:CYRUCvLKfyARjoJXLWAxce1qNUxTEtbRKAARkV42vpE=
github.com/jfrog/froggit-go v1.23.1 h1:4wmaHeuptxVINbovMaeITzVhi3+VQoc/FFIjF4axzu0=
github.com/jfrog/froggit-go v1.23.1/go.mod h1:wRDryqyp3oe+eHgME2mpnEQmO8XBECIPagFwj0nHmdI=
github.com/jfrog/go-mockhttp v0.3.1 h1:/wac8v4GMZx62viZmv4wazB5GNKs+GxawuS1u3maJH8=
Expand All @@ -406,8 +406,8 @@ github.com/jfrog/jfrog-apps-config v1.0.1 h1:mtv6k7g8A8BVhlHGlSveapqf4mJfonwvXYL
github.com/jfrog/jfrog-apps-config v1.0.1/go.mod h1:8AIIr1oY9JuH5dylz2S6f8Ym2MaadPLR6noCBO4C22w=
github.com/jfrog/jfrog-cli-application v1.0.2-0.20260723152309-34eeb81e2847 h1:wahxu7URLrhdHtI3CVH3aE1Y3eeubDin13t+QVJBeW8=
github.com/jfrog/jfrog-cli-application v1.0.2-0.20260723152309-34eeb81e2847/go.mod h1:p8yLtbmCxxQucIbLZKnWu0F+EDtj6NLXbRQCEK/nb6o=
github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260728121041-2227ac7420a0 h1:DVEYAyGJDn9ywGyBSa/MC3oWZsGC2DmPihv++/EDsJs=
github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260728121041-2227ac7420a0/go.mod h1:1vxzqW7jHBSuTNqO2vxEnhbniwq4dj5wveDuCMJX7Yo=
github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260804092100-37b49cc418e4 h1:TP3ZfPuIP7115f2UFxKHlWxNRXFCRGHMZ2GGzyztqrU=
github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260804092100-37b49cc418e4/go.mod h1:VfJ2ZjHFvKseWO6ZSg4oFNYU5MRPPAJjzXEgBSvinYY=
github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260728123939-34b27f070f2e h1:K0IK3w5a5h6SIi9yoOJ6a7DL+kuFjs5acypOxKyT2OM=
github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260728123939-34b27f070f2e/go.mod h1:MygQx8pekgPCXyXnejIAVG9S4ImGcDFmcfRPUug/0d0=
github.com/jfrog/jfrog-cli-evidence v0.9.5-0.20260618135203-4d2bdd4ee35f h1:MV4BATdkEoUYJmdPDvaB9EBb8JQZg28n/K4X7dcmyAY=
Expand Down
Loading
Loading