RTECO-1884 - Inconsistent inputs from github workflows for packages e2e tests - #3679
Open
naveenku-jfrog wants to merge 1 commit into
Open
RTECO-1884 - Inconsistent inputs from github workflows for packages e2e tests#3679naveenku-jfrog wants to merge 1 commit into
naveenku-jfrog wants to merge 1 commit into
Conversation
… package e2e workflows The jfrog_url/jfrog_admin_token (and jfrog_user/jfrog_password in apkTests.yml) workflow_dispatch inputs let a suite skip local Artifactory install and point at an external JPD instead. Run history shows these were never actually supplied on any manual dispatch, so every suite always installed Artifactory locally in practice. Removing the dead inputs, their passthrough to install-local-artifactory, and the now-always-empty JFROG_TESTS_IS_EXTERNAL conditionals from the go test invocations. apkTests.yml also had these inputs declared twice (workflow_call and workflow_dispatch) while every other suite only declared them under workflow_dispatch - both are removed for consistency. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
jfrog_url/jfrog_admin_tokenworkflow_dispatchinputs (plusjfrog_user/jfrog_passwordinapkTests.yml) exist in every package/Artifactory e2e workflow to let a manual run skip the local Artifactory install and point at an external JPD instead.Investigation into the reported "unused inputs" showed the wiring itself was correct in every workflow (passed through to
install-local-artifactoryand referenced in thego testinvocation) - but checking actualworkflow_dispatchrun history shows these inputs have never actually been supplied by anyone:jfrog_admin_tokenwas blank on every inspected run, and every run always took the local-install branch. In practice this is dead capability across the whole package/Artifactory suite set.This PR removes it:
jfrog_url/jfrog_admin_token(jfrog_user/jfrog_passwordfor apk)workflow_dispatchinputs from all 18 affected workflows.JFROG_URL/JFROG_ADMIN_TOKENpassthrough toinstall-local-artifactory- every suite now always installs Artifactory locally, matching actual usage.env.JFROG_TESTS_IS_EXTERNAL == 'true' && format(...) || ''conditional from the affectedgo testcommands (conanTests,gradleTests,mavenTests,nixTests,npmTests,nugetTests,pluginsTests,pnpmTests,poetryTests,pythonTests,rubyTests,artifactoryTests's project-suite step,transferTests's Artifactory-6 job).apkTests.yml: also removes the redundant duplicate inputs block (it declared the same inputs under bothworkflow_callandworkflow_dispatch, unlike every other suite which only declares underworkflow_dispatch), makes "Install local Artifactory" unconditional (was gated oninputs.jfrog_url == ''), and drops the deadcredsshell logic in the test-run step.poetryTests.ymlkeeps its unrelatedpoetry_versioninput untouched.accessTests.yml,helmTests.yml,huggingfaceTests.yml,lifecycleTests.yml, andtransferTests.yml's first job readenv.JFROG_TESTS_URL/env.JFROG_TESTS_LOCAL_ACCESS_TOKEN(set by the action regardless of local/external mode), notinputs.*directly, so theirgo testlines are unchanged.No behavioral change for the actual CI path: every suite already always installed Artifactory locally in every observed run; this just removes the unused override capability and the resulting dead conditionals.
Test plan
jfrog_url/jfrog_admin_token/jfrog_user/jfrog_password/JFROG_TESTS_IS_EXTERNALin the changed files🤖 Generated with Claude Code