Fix leading whitespace dropping the negative sign#69
Merged
dy merged 2 commits intoJun 29, 2026
Conversation
The global sign was decided by `str[0] === '-'`, reading the raw first character. The parser already tolerates leading whitespace for the magnitude (` 1h` parses to 3600000), but with a leading minus the sign check saw the whitespace instead of the `-`, so ` -1h` returned +3600000 rather than -3600000. Test the first non-whitespace character with `/^\s*-/` instead. This only affects a leading minus preceded by whitespace; the intentional mid-string-minus behavior (`1h-30m`, `2hr -40mins`) is unchanged since those inputs do not start with optional-whitespace-then-minus.
Collaborator
|
Regex is too heavy. Any way to make it simpler? Via trim I suppose? |
Contributor
Author
|
Good call — dropped the regex, now just |
There was a problem hiding this comment.
Pull request overview
Fixes an input-parsing bug where a leading whitespace before - caused negative durations to be interpreted as positive, aligning sign detection with the parser’s existing tolerance for leading whitespace.
Changes:
- Update sign detection to check the first non-whitespace character rather than
str[0]. - Add test coverage for negative durations preceded by spaces and tabs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| index.js | Adjusts sign detection to handle leading whitespace before -. |
| test.js | Adds regression tests for whitespace-prefixed negative inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global sign was decided by
str[0] === '-', reading the raw first character. The parser already tolerates leading whitespace for the magnitude (1h→ 3600000), but with a leading minus the sign check saw the whitespace instead of the-:Test the first non-whitespace character with
/^\s*-/instead. Only a leading minus preceded by whitespace is affected; the intentional mid-string-minus behavior (1h-30m,2hr -40mins) is unchanged.