refactor(test-evm-tools): derive fork-block activation from the transition schedule - #8
Closed
spencer-tb wants to merge 1 commit into
Closed
spencer-tb wants to merge 1 commit into
spencer-tb wants to merge 1 commit into
Conversation
Author
|
Superseded by ethereum#3557, the same change on forks/amsterdam without the EIP-8253 pieces, so ethereum#3535 can rebase onto it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the
fork_activationflag with the transition schedule. The filler hands the t8n the transition fork instead of the per-block resolution; the in-process EELS t8n resolves the block's side of the boundary itself and, when that side has fork-block logic (is_fork_blockin itsforkmodule), runs it with the transition's activation criteria via the existingForkCacheoverride, so the spec's own predicate decides whether the EIP-8253 bump applies.ethereum-spec-evm t8naccepts transition names such asBPO2ToAmsterdamAtTime15kfor the same purpose. Legacy aliases (HomesteadToDaoAt5) keep theirfind_forkpath.External tools are unchanged: they still receive the resolved per-block fork name and no activation information, checked by driving a geth-classified wrapper through a transition test (
--state.fork=BPO2, then=Amsterdam).Fixtures are identical to the flag version, ignoring
_info: the EIP-8253 directory (154 cases on this base) and the 7928, 7997, 8037, 8282 and 4844 transition tests (241 cases). Cloning a fork with overridden criteria costs about six seconds once per worker, only for forks with fork-block logic.Related Issues or PRs
Framework follow-up to ethereum#3535; independent of #7.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.