Fix 500 on .lua file upload from closed-file write#47
Merged
Conversation
perform_update closed the uploaded file's stream via a context manager before handing it to the storage backend, which then failed trying to re-read it. Validate and normalise the content directly, then save it as a fresh ContentFile instead of reusing the original upload stream.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProfileUserView.perform_updatevalidated and rewrote the uploaded.luafile in place viawith file.open("r+") as f: ..., which closes the underlying stream on exit. The closed file was then passed toserializer.save(), which crashed when the storage backend tried to read it again (ValueError: I/O operation on closed file) — this hit every upload, not just large ones, since Django'sInMemoryUploadedFiledoesn't overrideFile.close().ContentFilebuilt from the normalised bytes instead of reusing the original (now-closed) upload stream.Test plan
ValueErroragainst the pre-fix code and passes against the fixpytest tests/(34 passed)ruff check