Fix 500 reading uploaded addon file in text mode#48
Merged
Conversation
ProfileUserView.list opened the stored .lua file with mode "r" (text),
so readlines() already returned str, and the subsequent .decode("utf-8")
call crashed. This path was previously unreachable in practice (no page
read the file before page=addon was added) so the bug went unnoticed.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProfileUserView.listopened the stored.luafile withuser_obj.user_file.open("r")(text mode), sof.readlines()already returnedstrlines, and the subsequentline.decode("utf-8")call crashed withAttributeError: 'str' object has no attribute 'decode'.page=addon(PR Serve gold and played time from cached addon file #46) but was never exercised in practice, since nothing previously called?page=with anything other thanheader. Fixed by opening in binary mode ("rb"), matching what the decode call expects.Test plan
page=addon; reproduces the exactAttributeErroragainst the pre-fix code and passes against the fixpytest tests/(35 passed)ruff check