Parse addon gold/played-time into a DB table on upload#49
Merged
Conversation
Replaces the page=addon read-through cache (which re-parsed the raw .lua file on every cache miss, with no expiry) with parse-on-upload into a new ProfileAltAddonData model, matching how every other Profile* model is populated. Adds the altaddondata endpoint and drops the now-dead generic file-read branch from ProfileUserView.list.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProfileAltAddonDatamodel (altOneToOne PK,gold,played_time_total,played_time_level) plus migration, matching the existingProfileAltMythicPluspattern.ProfileUserView.perform_updatenow parses the uploaded.luafile once and upsertsProfileAltAddonDataper matching alt, instead ofProfileUserView.listre-parsing the raw file on every cache miss with an indefinite cache (page=addon, no TTL). A failed parse logs a warning without failing the upload.altaddondataendpoint (ProfileAltAddonDataView), sameIsSessionUser-style enforcement asaltmythicplus. Removed the now-dead generic file-read branch andpage=addonfromProfileUserView.list.Test plan
ProfileAltAddonDatapopulated with correct values)pytest tests/(38 passed)ruff checkmakemigrations/migrateapplied cleanly