Add CSP nonce support to Django profiling pages - #459
Open
RRXXZZYY wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PYINSTRUMENT_CSP_NONCEcallback for Django middlewareWhy
Django applications whose CSP disallows inline scripts currently need to relax
script-srcto display the profiling page. A per-response nonce lets the application authorize Pyinstrument's two inline scripts without enablingunsafe-inline.Closes #306.
Verification
pytest -qthrough a temporary ASCII path alias on Windows: 133 passed, 11 skipped (with one Trio signal-handling warning)prek run --all-files: passed (ruff, formatting, codespell, pyright, repository hooks, and JS bundle rebuild)Unverified boundaries
AI assistance
AI assistance was used to investigate, implement, test, and review this change. The final diff and generated artifacts were checked, and all verification results above are from commands actually run.