Fix plugin Filter exclusion accounting - #351
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: 59f26e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joesobo
marked this pull request as ready for review
August 6, 2026 18:01
joesobo
marked this pull request as draft
August 7, 2026 14:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Active plugin default Filters can remove workspace files before analysis, but the Filters control only counted Nodes removed later in the Graph View. The control could therefore report zero while plugin Filters visibly reduced graph membership.
Fix
.gitignorestay conceptually separate. This change does not alter any plugin default Filter.Verification
pnpm --filter @codegraphy-dev/extension typecheckVisual proof
Before plugin activation: 19 Nodes, no active Filters, and 0 workspace files excluded before analysis.
After enabling the TypeScript plugin defaults and re-indexing: 18 Nodes and 1 workspace file excluded before analysis. Graph View exclusions remain a separate 0-Node metric.
Trello
Trello #242