fix: restore ModelSetupCoordinator.swift and anchor the Models/ gitignore rule#40
Open
hiimdec wants to merge 1 commit into
Open
fix: restore ModelSetupCoordinator.swift and anchor the Models/ gitignore rule#40hiimdec wants to merge 1 commit into
hiimdec wants to merge 1 commit into
Conversation
…nore Commit 5214b77 ("chore: Refactor directories") moved the file into KeyType/Logic/Models/, but .gitignore's bare "Models/" pattern (intended for model-weights directories) matches ANY directory named Models at any depth — so git silently dropped the file from the move commit and every fresh clone fails to build, while it survives untracked in the author's working copy. - Anchor the pattern to the repo root (/Models/); *.gguf still catches strays. - Restore the file verbatim from 5214b77^ at the path project.pbxproj expects. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38.
maindoes not build from a fresh clone:project.pbxprojreferencesKeyType/Logic/Models/ModelSetupCoordinator.swift, but the unanchoredModels/rule in.gitignore(meant for model weights) also matches theKeyType/Logic/Models/source directory, so the directory refactor in 5214b77 recorded the move as a pure deletion and the file was never re-added.This PR:
ModelSetupCoordinator.swiftverbatim from5214b77^(the last committed version) at the path the project expects;/Models/, with a comment) so an ignored directory name can't swallow source files again.Verified on a clean checkout of
main(04db9a2), macOS 26.5.1 / Xcode 26.6: without this change the build fails withand with it the same invocation ends in
BUILD SUCCEEDED.Heads-up: if the untracked copy of this file in your working tree has evolved since 5214b77, prefer committing your version on top of this — once the gitignore rule is anchored,
git statuswill show it.🤖 Generated with Claude Code