Skip to content

🔒 Fix: Unvalidated Input in ANSI RGB Parser #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnstrand merged 6 commits into from
Jun 20, 2026
Merged

🔒 Fix: Unvalidated Input in ANSI RGB Parser #7

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7cd774b
🔒 fix: Use TryParse in ANSI parser to prevent unhandled exceptions on…
google-labs-jules[bot] Jun 20, 2026
9c9fcdb
Merge branch 'master' into jules/security-fix-ansi-parser-56317915466…
johnstrand Jun 20, 2026
99ac4cd
🔒 fix: Use TryParse in ANSI parser to prevent unhandled exceptions on…
google-labs-jules[bot] Jun 20, 2026
2698cab
Merge branch 'master' into jules/security-fix-ansi-parser-56317915466…
johnstrand Jun 20, 2026
616270d
WIP
johnstrand Jun 20, 2026
fc84d58
🔒 fix: Use TryParse in ANSI parser to prevent unhandled exceptions on…
google-labs-jules[bot] Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions src/GameUtils/Term/Ansi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,14 +340,11 @@ public static string Format(string text)
{
var rgb = sequence[4..].Split(',');

if (rgb.Length != 3)
if (rgb.Length != 3 || !byte.TryParse(rgb[0], out var r) || !byte.TryParse(rgb[1], out var g) || !byte.TryParse(rgb[2], out var b))
{
throw new ArgumentException($"Invalid RGB color sequence starting at position {i}");
}

var r = byte.Parse(rgb[0]);
var g = byte.Parse(rgb[1]);
var b = byte.Parse(rgb[2]);
result.Append(Foreground(r, g, b));
continue;
}
Expand All @@ -356,14 +353,11 @@ public static string Format(string text)
{
var rgb = sequence[4..].Split(',');

if (rgb.Length != 3)
if (rgb.Length != 3 || !byte.TryParse(rgb[0], out var r) || !byte.TryParse(rgb[1], out var g) || !byte.TryParse(rgb[2], out var b))
{
throw new ArgumentException($"Invalid RGB color sequence starting at position {i}");
}

var r = byte.Parse(rgb[0]);
var g = byte.Parse(rgb[1]);
var b = byte.Parse(rgb[2]);
result.Append(Background(r, g, b));
continue;
}
Expand All @@ -372,14 +366,11 @@ public static string Format(string text)
{
var rgb = sequence[1..].Split(',');

if (rgb.Length != 3)
if (rgb.Length != 3 || !byte.TryParse(rgb[0], out var r) || !byte.TryParse(rgb[1], out var g) || !byte.TryParse(rgb[2], out var b))
{
throw new ArgumentException($"Invalid RGB color sequence starting at position {i}");
}

var r = byte.Parse(rgb[0]);
var g = byte.Parse(rgb[1]);
var b = byte.Parse(rgb[2]);
result.Append(Foreground(r, g, b));
continue;
}
Expand Down
Loading