Share task timing option parsing

[jolovicdev]

Summary

• centralize conversion of numeric task timing options into timedelta values
• reuse the same parsing path when importing exported task metadata
• cover export/import preservation for timeout and ttl settings

Validation

• uv run ruff check src/ tests/
• uv run pyright src/
• uv run pytest tests/ -v

[ds-review]

PR Review

PR: Share task timing option parsing

Important

Verdict: Request changes - 1 actionable finding, highest severity P1.

Findings (1)

duration_from_seconds converts 0 to None

src/cashet/_client_base.py:59

The function uses truthiness (if seconds) to decide whether to return a timedelta. Passing 0 or 0.0 evaluates to False, so the function returns None instead of timedelta(0). This silently changes the behavior from the previous explicit None check, where a zero timeout or TTL was preserved. A zero timeout can be meaningful (e.g., no delay or immediate expiration), so collapsing it to None is incorrect.

How To Recheck

Reply @ds-review recheck under the relevant inline finding after pushing a fix.

[ds-review]

duration_from_seconds converts 0 to None

The function uses truthiness (if seconds) to decide whether to return a timedelta. Passing 0 or 0.0 evaluates to False, so the function returns None instead of timedelta(0). This silently changes the behavior from the previous explicit None check, where a zero timeout or TTL was preserved. A zero timeout can be meaningful (e.g., no delay or immediate expiration), so collapsing it to None is incorrect.

Suggested change

	return timedelta(seconds=seconds) if seconds else None
	return timedelta(seconds=seconds) if seconds is not None else None

[jolovicdev]

@ds-review recheck

[ds-review]

Recheck: resolved. The duration_from_seconds function now uses if seconds is not None instead of truthiness, so passing 0 returns timedelta(0) instead of None.

[ds-review]

Automated PR review encountered an error and could not complete.