chore: version packages - #72
Merged
Merged
Conversation
Deploying effex-api with
|
| Latest commit: |
f1d2342
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e89d0493.effex-api.pages.dev |
| Branch Preview URL: | https://changeset-release-main.effex-api.pages.dev |
Deploying effex with
|
| Latest commit: |
f1d2342
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8b471a9e.effex.pages.dev |
| Branch Preview URL: | https://changeset-release-main.effex.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@effex/dom@1.4.4
Patch Changes
ec2ad34: Fix enter animations firing against a detached element on nested
client-mode re-mounts (e.g. router nav-back on pages with animations
deep inside the route's tree).
forkSlotEnterforks the animation fiber viaEffect.forkIn(slotScope)from inside
addSlot. Effect's scheduler can hand that fiber controlon the next microtask, before the outer synchronous render flow has
finished appending the wrapper's ancestor chain into the document.
When that happens,
onBeforeEnterfires against a node whose ancestorsaren't yet in the DOM —
getComputedStylereturns empty strings ondisconnected nodes, and browsers won't compute or transition styles
against them, so the enter transition never fires and the animation
stalls to the timeout.
On first render this didn't surface because hydration walks pre-existing
DOM: every element was already connected when the fiber ran. It only
broke on subsequent client-mode mounts, and only when the animated
block sat inside another wrapper element (its own ancestor had to be
appended AFTER the fork).
The animation fiber now yields microtasks until the element is
connected, up to a small bound. In practice the outer flow completes
within one or two microtasks; the bound ensures callers that never
insert their result (e.g. tests that yield an animated element without
appending it to the document) still make progress instead of hanging.
Regression test in
Control.test.tsassertselement.isConnectedistrue at
onBeforeEnteron both the initial mount AND the toggle-backof a
when-nested animated block that lives two wrappers deep.@effex/router@1.3.4
Patch Changes
docs@0.0.27
Patch Changes