Skip to content

Batch completion: probe from the newest tracking row (3/3, no measured gain) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpcamara wants to merge 1 commit into from
Open

Batch completion: probe from the newest tracking row (3/3, no measured gain) #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/models/solid_queue/batch_execution.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@ def finish_batch_for(batch_id)
# is. Asking the cheap question first means the batch row is only read
# for the job that actually finishes the batch. #finish asks it again, so
# this decides nothing on its own.
return if where(batch_id: batch_id).exists?
#
# Looking from the newest row backwards, because a batch drains roughly
# in id order: the rows still outstanding are the ones at the end, while
# the beginning of the range is whatever the finished jobs left behind.
return if where(batch_id: batch_id).order(id: :desc).pick(:id)

# Skip the serialized callback and metadata columns on this hot path
if batch = Batch.select(:id, :finished_at, :enqueued_at).find_by(id: batch_id)
Expand Down