Skip to content

Batch completion: skip the batch row read for jobs that aren't last (1/3) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpcamara wants to merge 1 commit into from
Open

Batch completion: skip the batch row read for jobs that aren't last (1/3) #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/models/solid_queue/batch_execution.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ def count_new_jobs_among(jobs)

private
def finish_batch
# Every finishing job asks whether it was the last one, and almost never
# is. Asking the cheap question first means the batch row is only read
# for the job that actually finishes the batch. #finish asks it again, so
# this decides nothing on its own.
return if self.class.where(batch_id: batch_id).exists?

# Skip the serialized callback and metadata columns on this hot path
if batch = Batch.select(:id, :finished_at, :enqueued_at).find_by(id: batch_id)
batch.finish
Expand Down