Cap the state column at 1 GB - 1 so Postgres migrates - #74
Open
jpcamara wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The yrby:tables migration template set
t.binary :state, limit: 4.gigabytes - 1. Postgres raisesArgumentError: No binary type has byte size 4294967295for binary limits above 1 GB - 1 (every Rails from 7.0 through 8.1), sodb:migrateon a fresh Postgres app failed — including installs arriving through gems that invoke yrby:tables. Verified against a real Postgres: the old limit raises, the new one createsbyteacleanly.1.gigabyte - 1is the largest limit every adapter accepts: MySQL maps anything over 16 MB tolongblob(unchanged — the original value's intent), SQLite ignores limits, Postgres sits exactly at its cap. The payload column's 16 MB - 1 is under the cap and stays.Apps that already migrated are unaffected; the generator comment and test track the new value.