Make WEBHOOK_SECRET mandatory unless --insecure is set#1
Merged
Conversation
mgol
approved these changes
Jun 22, 2026
mgol
left a comment
mgol
left a comment
Member
There was a problem hiding this comment.
The changes make sense to me (I just have a small code style remark), but I haven't worked with these notifiers directly, so if you want a more thorough review, feel free to find someone with more experience here.
| // Invalid signature, discard unauthorized event | ||
| return; | ||
| } | ||
| } else if (!this.allowInsecure) { |
Member
There was a problem hiding this comment.
A minor code style remark: for these security-related checks, I feel it's easier to see that we're well protected if these checks are done at the top, as soon as possible, and that we immediately return if they are not fulfilled (possibly preceded by issuing error logs, throwing, etc. - whatever makes sense).
timmywil
approved these changes
Jun 22, 2026
Reduce chances of misconfiguration by explicilty refusing to start without a secret for payload verification, unless it is explicitly disabled. Credit to Quarkslab for the discovery and recommended mitigation. Ref jquery/infrastructure#526 Ref jquery/infrastructure#565
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce chances of misconfiguration by explicilty refusing to start without a secret for payload verification, unless it is explicitly disabled.
Credit to Quarkslab for the discovery and recommended mitigation.
Ref https://github.com/jquery/infrastructure/issues/526
Ref https://github.com/jquery/infrastructure/issues/565