github-notifier: Restore MAX_BODY_LENGTH and raise from 200 kB to 1 MiB#2
Merged
Conversation
Follows-up 0e9aa90 which introduced MAX_BODY_LENGTH, and fec6bd9 which removed it again due to being too low for static site deployments where small changes often change all files and thus produce fairly large GitHub Push eventsm because they are essentially a JSON wrapper around `git show` with a full file listing. GitHub Docs promise to limit the 'added', 'removed', and 'changed' arrays to 5000 file paths each (if more, the array is capped, in favor of recommending you call their API for the full details instead), or 25 MB overall (event is dropped by them if still larger than that). Note that we don't need any of this information, but there's no way to opt-out of this afaik. Note that we did not actually remove the limit in that patch in practice, because we run it with Nginx in front, and that limits the request body to 1MiB. That has been large enough so reflect that in the Node.js service directly as well, to benefit other potential users of the package. Credit to Quarkslab for the discovery and recommended mitigation. Ref jquery/infrastructure#565.
timmywil
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows-up 0e9aa90 which introduced MAX_BODY_LENGTH, and fec6bd9 which removed it again due to being too low for static site deployments where small changes often change all files and thus produce fairly large GitHub Push eventsm because they are essentially a JSON wrapper around
git showwith a full file listing.GitHub Docs promise to limit the 'added', 'removed', and 'changed' arrays to 5000 file paths each (if more, the array is capped, in favor of recommending you call their API for the full details instead), or 25 MB overall (event is dropped by them if still larger than that).
Note that we don't need any of this information, but there's no way to opt-out of this afaik.
Note that we did not actually remove the limit in that patch in practice, because we run it with Nginx in front, and that limits the request body to 1MiB. That has been large enough so reflect that in the Node.js service directly as well, to benefit other potential users of the package.
Credit to Quarkslab for the discovery and recommended mitigation.
Ref https://github.com/jquery/infrastructure/issues/565.