Modernize the public Codex field guide - #4
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 354e1c0fa7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if not isinstance(value, str): | ||
| return False | ||
| try: | ||
| return date.fromisoformat(value).isoformat() == value |
There was a problem hiding this comment.
When a contributor supplies a future value such as 9999-12-31, this helper returns true and the catalog, asset-manifest, and product-source checks all accept it. The problem is already visible in this commit: the catalog, manifest, README, and product guides claim updates or reviews on 2026-08-20, while the commit was authored and committed on 2026-08-19 UTC. Compare parsed dates with the current date so CI cannot certify reviews or updates that have not yet occurred.
Useful? React with 👍 / 👎.
| "script content": r"<script\b", | ||
| "event-handler attribute": r"\son[a-z]+\s*=", | ||
| "active or embedded href": r"(?:href|xlink:href)\s*=\s*['\"]\s*(?:javascript:|data:)", | ||
| "external href": r"(?:href|xlink:href)\s*=\s*['\"]\s*https?://", |
There was a problem hiding this comment.
When an SVG contains a scheme-relative reference such as <image href="//tracker.example/pixel">, this expression does not match it, and URL_PATTERN also misses it because that pattern requires http:// or https://. A browser can resolve and request that external resource when the asset is rendered, so such an SVG passes the new metadata/privacy gate despite retaining an external dependency; reject // and other externally resolving href forms as well.
Useful? React with 👍 / 👎.
1 participant
Summary
Security and privacy
contents: read, disables persisted checkout credentials, uses a bounded runner and timeout, and pins actions to reviewed commit SHAsValidation
python3 -m unittest discover -s tests -vpython3 scripts/validate_content.pypython3 -m py_compile scripts/validate_content.py tests/test_validate_content.pygit diff --checkactions/checkoutv7 andactions/setup-pythonv7Release boundary
This publishes a public-alpha documentation update only. It does not create a release, change repository settings, apply the custom social preview, or claim beta/stable maturity.