fix: correct opt-in ServletEnv charset mismapping when parsing query strings - #481
Merged
Merged
Conversation
…y strings Also unifies the query parsing on Rack 2.2's proper validated parser and compares against DefaultEnv.
chadlwilson
force-pushed
the
1.3-servlet-env-tidy
branch
from
September 8, 2026 09:43
0ba2294 to
c454e0b
Compare
chadlwilson
changed the title
ServletEnv charset mismapping when parsing query strings
chadlwilson
marked this pull request as ready for review
September 8, 2026 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also unifies the query parsing on Rack 2.2's proper validated parser and compares against DefaultEnv in specs.
This makes migration to Rack 3 much easier since we are re-using a version-appropriate parser.
This should be low risk, as the ServletEnv is opt-in, and to my knowledge doesn't seem frequently used (still marked as EXPERIMENTAL).