Fix defects in new-plugin/new-extension/new-timeline scaffolds#56
Merged
Conversation
🦋 Changeset detectedLatest commit: f7454a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- CITATION.cff: stop injecting the full author name into family-names,
given-names, and name-particle; remove unsubstituted {email}/{softwareUrl}/
{title} placeholders (new-plugin, new-extension)
- README "Loading" snippet: import from the scoped npm package name and close
the in-browser <script> tag (new-plugin, new-extension)
- examples/index.html: load the local build as a live <script> instead of
leaving it commented out in the "once published" block
- new-timeline: build the browser bundle as dist/index.browser.min.js via a
tsup.config.ts to match the unpkg field and the other packages
- ship a .gitignore in generated packages (as "gitignore", renamed during
scaffolding to avoid npm rewriting it to .npmignore on publish)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
5a3da31 to
f7454a7
Compare
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several defects encountered while using the
new-pluginscaffold (and the equivalent bugs innew-extension/new-timeline).Fixes
family-names,given-names, andname-particlesimultaneously, and remove the{email}/{softwareUrl}/{title}/{linkToPublicationInJournal}placeholders that were never substituted. These are now clean fill-in fields.@jspsych-contrib/plugin-xinstead ofplugin-x) and close the in-browser<script>tag.<script>instead of leaving it commented out inside the "once published" block. This was fatal for the JS templates, which previously had no live local script at all.dist/index.browser.min.js(via a newtsup.config.ts) to match theunpkgfield and the other packages, instead ofdist/index.global.js..gitignorescaffolding: generated packages now include a.gitignore(ignoringdist/andnode_modules/). The template ships asgitignoreand is renamed during scaffolding so npm doesn't rewrite it to.npmignoreon publish. Adopted PR auto-generate documentation from JSDoc strings for timelines #38'sdot: trueglob option as well.Notes / relationship to #38
This overlaps with #38 (
generate-readme-from-docstrings) and will conflict in two places where these are the more complete fixes:new-plugin/new-extensioncli.jspublishing-comment blocknew-timeline/templates/timeline-template-ts/package.json(this PR switchesbuildtotsup+ a config file; auto-generate documentation from JSDoc strings for timelines #38 adds anupdate-readmescript +@jspsych-dev/generate-timeline-docsdep). These two need hand-merging.Verification
cli.jsfiles parse (node --check).tsupbrowser-bundle rename and thegitignore→.gitignorescaffolding rename were not run end-to-end (templatenode_modulesaren't installed in this checkout) — worth a quicknpx @jspsych/new-plugin/new-timelinesmoke test before release to confirm a generated package contains.gitignoreanddist/index.browser.min.js.🤖 Generated with Claude Code