fix(ci): honor per-caller Docker pull inputs in Linux fresh-host job#192
Merged
Conversation
jsugg
force-pushed
the
wire-linux-fresh-host-pull-inputs
branch
from
40aab51 to
0a27753
Compare
The Linux fresh-host job read its Docker-pull tuning from the reusable workflow's top-level env, so it ignored the per-caller docker_pull_* inputs that only the macOS job wired through. The Linux prepull therefore ran at a hard-coded parallelism of 4 regardless of the requested 2, and the retry budget could not be tuned per caller. Wire the Linux job to honor the inputs (mirroring macOS) and drop the dead top-level fallbacks so the inputs are the single source of truth. Standardize the retry budget to 5 across callers so the registry backoff stays effective, and correct the input descriptions that wrongly claimed macOS-only scope. Net: parallelism 2 and retry budget 5 on both platforms across all lanes. Add a contract test locking the wiring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the registry-backoff fix. The Linux fresh-host job read the Docker-pull tuning from the reusable workflow's top-level
env, so it silently ignored the per-callerdocker_pull_*inputs — only the macOS job wired them through. As a result the Linux prepull ran at a hard-coded parallelism of4regardless of what callers requested (2), and the retry budget could only be tuned globally.This wires the Linux job to honor the per-caller inputs, exactly like the macOS job, and removes the now-dead top-level fallbacks so the inputs are the single source of truth.
Changes
fresh-host-core.yml: add theFRESH_HOST_SELECTED_DOCKER_PULL_PARALLELISM/FRESH_HOST_SELECTED_DOCKER_PULL_MAX_ATTEMPTSenv to thelinux-fresh-hostjob (mirrors the macOS job); remove the hard-coded top-levelFRESH_HOST_DOCKER_PULL_PARALLELISM/FRESH_HOST_DOCKER_PULL_MAX_ATTEMPTSenv; raise thedocker_pull_max_attemptsinput default to5.nightly.yml/fresh-host-acceptance.yml: set the retry-budget inputs to5so the budget is preserved now that Linux honors them; correct the input descriptions that wrongly said "macOS" only.SELECTEDpull env to the inputs and that the dead top-level fallbacks stay gone.Net effect (consistent across Linux + macOS, all lanes)
2everywhere (was Linux4, macOS2) — honors the configured value and reduces concurrent registry pressure.5everywhere (was Linux5, macOS3) — keeps the exponential registry backoff effective on both platforms.