Skip to content

⚡ Optimize renderSets performance #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julesklord wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize renderSets performance #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,7 @@ function renderSets(){
area.innerHTML='<div style="display:flex;align-items:center;justify-content:center;height:100%;color:var(--text3);font-family:var(--font-mono);font-size:12px;flex-direction:column;gap:8px;"><div>No sets generated yet.</div><div style="font-size:10px;">Click Generate Setlist in the sidebar.</div></div>';
return;
}
const poolOptions = pool.map(s=>`<option value="${esc(s.id)}">${esc(s.title)} — ${esc(s.artist)}</option>`).join('');
sets.forEach((songs,si)=>{
const ep=Math.round((songs.reduce((a,s)=>a+s.energy,0)/(songs.length*5||1))*100);
const card=document.createElement('div');
Expand All @@ -537,7 +538,7 @@ function renderSets(){
<div class="add-row">
<select class="add-sel" id="as-${esc(si)}">
<option value="">+ Add song…</option>
${pool.map(s=>`<option value="${esc(s.id)}">${esc(s.title)} — ${esc(s.artist)}</option>`).join('')}
${poolOptions}
</select>
<button class="add-btn" onclick="addToSet(${esc(si)})">Add</button>
</div>`;
Expand Down
Loading