Skip to content

🧪 [testing] add unit tests for normalizeInstr #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julesklord wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🧪 [testing] add unit tests for normalizeInstr #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1623,6 +1623,7 @@ if (typeof module !== 'undefined' && module.exports) {
cleanJSON,
encryptApiKey,
decryptApiKey,
parseCSVLine
parseCSVLine,
normalizeInstr
};
}
52 changes: 52 additions & 0 deletions tests/run-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,58 @@ runTest('Truncates prog field to 40 characters', () => {

console.groupEnd();

// 6. Tests for normalizeInstr
console.group('\n✅ Test Group: normalizeInstr');

runTest('Returns ["g"] for non-array input', () => {
assertArrayEqual(normalizeInstr(null), ['g']);
assertArrayEqual(normalizeInstr(undefined), ['g']);
assertArrayEqual(normalizeInstr('guitar'), ['g']);
assertArrayEqual(normalizeInstr(123), ['g']);
assertArrayEqual(normalizeInstr({}), ['g']);
});

runTest('Returns ["g"] for empty array', () => {
assertArrayEqual(normalizeInstr([]), ['g']);
});

runTest('Maps instrument names to internal codes', () => {
assertArrayEqual(normalizeInstr(['guitar']), ['g']);
assertArrayEqual(normalizeInstr(['guitarra']), ['g']);
assertArrayEqual(normalizeInstr(['piano', 'keyboards', 'keys']), ['p']);
assertArrayEqual(normalizeInstr(['winds', 'wind', 'brass', 'horns']), ['v']);
assertArrayEqual(normalizeInstr(['voice', 'vocals', 'vocal', 'voz', 'singing']), ['o']);
});

runTest('Accepts existing codes', () => {
assertArrayEqual(normalizeInstr(['g', 'p', 'v', 'o']), ['g', 'p', 'v', 'o']);
});

runTest('Handles case-insensitivity and trimming', () => {
assertArrayEqual(normalizeInstr([' GUITAR ', 'Vocals ']), ['g', 'o']);
});

runTest('Removes duplicates in the resulting codes', () => {
assertArrayEqual(normalizeInstr(['guitar', 'guitarra', 'g']), ['g']);
assertArrayEqual(normalizeInstr(['piano', 'keys', 'p', 'vocals', 'o']), ['p', 'o']);
});

runTest('Filters out invalid instruments', () => {
assertArrayEqual(normalizeInstr(['guitar', 'invalid-instrument', 'piano']), ['g', 'p']);
});

runTest('Returns ["g"] if all instruments in array are invalid', () => {
assertArrayEqual(normalizeInstr(['invalid1', 'invalid2']), ['g']);
});

runTest('Handles non-string elements by converting to string', () => {
// Map expects strings. String(null) is "null", String(1) is "1".
// None of these are in the MAP, so it should filter them out and return ['g']
assertArrayEqual(normalizeInstr([1, null, true]), ['g']);
});

console.groupEnd();

console.log(`\n=============================================`);
console.log(`Test Summary: ${passed} passed, ${failed} failed`);
console.log(`=============================================`);
Expand Down
Loading