[very breaking] Fix dual sign of equalities - #235
Open
joaquimg wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #235 +/- ##
==========================================
- Coverage 95.22% 95.18% -0.04%
==========================================
Files 17 17
Lines 858 852 -6
==========================================
- Hits 817 811 -6
Misses 41 41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joaquimg
changed the title
blegat
reviewed
Aug 24, 2026
| ), | ||
| # Classical free variable. | ||
| # The value is used as is: dual constraints are built as | ||
| # `-A_{.j}^T y + a_j in V_j^*` for every primal variable, whether the |
Member
There was a problem hiding this comment.
Thanks for the comment Claude but it won't make sense for a reader of the code without this PR as context ^^
He always does that, it's funny.
Not sure we need to keep it
blegat
reviewed
Aug 24, 2026
|
|
||
| Used as pre-processing for `MOI.set`ting `value` for a variable. | ||
| """ | ||
| function dual_attribute_value_set end |
blegat
reviewed
Aug 24, 2026
| ``` | ||
|
|
||
| Note that the equality constraints have minus signs that could be flipped for | ||
| simplicity. However, for generality, we keep the minus signs so that the models |
Member
There was a problem hiding this comment.
I'm a bit surprised that "we keep the minus sign" is stated before and after the PR. Didn't we change the behavior here ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #70 (with some claude help)