-
Notifications
You must be signed in to change notification settings - Fork 6
cuOpt v26.02 support #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7dc341e
5314deb
40c1677
c2ff156
6164bc2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,4 +18,4 @@ | |
| Clang = "40e3b903-d033-50b4-a0cc-940c62c95e31" | ||
|
|
||
| [compat] | ||
| Clang = "0.17" | ||
| Clang = "0.19" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the most recent Clang version |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,7 +46,7 @@ function __init__() | |
| error("Failed to get cuOpt library version (status code: $status)") | ||
| end | ||
| version = VersionNumber(major[], minor[], patch[]) | ||
| min, max = v"25.08", v"25.13" | ||
| min, max = v"26.02", v"26.03" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This effectively restricts to only v26.02
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay, so now a big question: is this a breaking change for users? How do they ensure they get the right combination of cuOpt and cuOpt.jl versions? Can we document the compat matrix?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suppose so, yes, given that
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The README currently states supported cuOpt versions under installation instructions.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @mlubin
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As long as we tag this as 0.2, this seems fine to me. |
||
| if !(min <= version < max) | ||
| error( | ||
| "Incompatible cuOpt library version. Got $version, but supported versions are [$min, $max)", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,10 +56,10 @@ function test_runtests_cache_optimizer() | |
| ], | ||
| ); | ||
| exclude = [ | ||
| # Upstream bug: https://github.com/NVIDIA/cuopt/issues/260 | ||
| "test_constraint_ZeroOne_bounds_3", | ||
| # Upstream bug: https://github.com/NVIDIA/cuopt/issues/112 | ||
| # upstream bug https://github.com/NVIDIA/cuopt/issues/923 | ||
| "test_solve_TerminationStatus_DUAL_INFEASIBLE", | ||
| "test_linear_DUAL_INFEASIBLE", | ||
| "test_linear_DUAL_INFEASIBLE_2", | ||
|
Comment on lines
+59
to
+62
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The upstream bugs that caused previous exclusions were fixed, but I encountered a new one (see upstream issue) so had to exclude these. |
||
| ], | ||
| ) | ||
| return | ||
|
|
@@ -73,7 +73,9 @@ function test_air05() | |
| MOI.set(model, MOI.RawOptimizerAttribute(cuOpt.CUOPT_TIME_LIMIT), 60.0) | ||
| MOI.copy_to(model, src) | ||
| MOI.optimize!(model) | ||
| @test MOI.get(model, MOI.TerminationStatus()) == MOI.OPTIMAL | ||
| # upstream bug: https://github.com/NVIDIA/cuopt/issues/855, should be fixed in 26.04 | ||
| # @test_broken to be fixed when upgrading to cuopt 26.04 | ||
| @test_broken MOI.get(model, MOI.TerminationStatus()) == MOI.OPTIMAL | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Upstream bug is fixed on master, so |
||
| @test isapprox(MOI.get(model, MOI.ObjectiveValue()), 26374.0; rtol = 1e-4) | ||
| return | ||
| end | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.