perf(sync): read each collection once per pull page, not once per record - #384
Merged
kYem merged 2 commits intoOct 4, 2026
Conversation
kYem
deleted the
kes/eng-153-sync-a-pull-re-reads-the-whole-collection-for-every-record
branch
October 4, 2026 03:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ENG-153
resolveAndApplyread the whole collection for every pulled record, so a page of N records cost N full reads. Each page now reads a collection once (LocalCopiesonPullState) and mirrors the pull's own writes into it. It re-reads per page, so an edit landing mid-listing is seen within a page.The 500-plus-record paging tests drop from ~230–460ms to ~40–80ms locally, so the 30s timeouts from #383 are removed.