feat(reminders): show an in-app card with done and snooze when a reminder fires - #387
Merged
kYem merged 5 commits intoOct 4, 2026
Conversation
kYem
deleted the
kes/eng-140-reminders-show-an-in-app-card-with-snooze-done-when-a
branch
October 4, 2026 07:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ENG-140
reminderPrompts, not synced: each device fires its own wakes). Every open tab watches it; only the focused, visible tab shows the card, above the bell.respondToReminder, which the notification buttons now use too, so both behave identically. Answering anywhere clears the notification and the prompt, so other tabs' cards go away. Moving that code out of the worker also makes the notification's Done/Snooze callnotifyMutated, which it didn't before.Decisions:
enableNotificationsis the Pomodoro session switch and reminders deliberately ignore it, so the card always shows.Tests: unit tests for the prompts list,
respondToReminder, the store and the card; a new real-extension e2ereminder-prompt-card.spec.ts(fire in the worker → card on the page → Done completes it and closes the notification); all 10 extension e2e specs pass. Screenshots in all four themes were checked locally.