Repository navigation
fix(pomodoro): stop sound on leaving the Pomodoro page - #390
Merged
Merged
Conversation
…tart modes With auto-start off, a sound started on the Pomodoro page kept playing on home with no control. Leaving the page now stops what this tab plays; another tab's sound is left alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ENG-145
Chosen behaviour: sound follows the Pomodoro page. Leaving
#pomodorostops what this tab is playing, in both auto-start modes; another tab's sound is left alone. Replaces #386.Out of scope: turning focus music off while a sound plays hides its control on Pomodoro (already on main).