ci: bound the valgrind apt install with a hard timeout and retry - #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The memcheck step's
apt-getpreamble has stalled with zero output three times now (the runs for #811, #815, #819), each sitting until a step or job timeout. #817 addedAcquire::*::Timeoutoptions, but those only bound an HTTP read — the stalls in practice hang earlier (DNS, the dpkg lock, or sudo itself), so they slipped past.This wraps each apt call in a hard
timeout 240and retries the pair once after a short sleep, so a wedge fails fast wherever it occurs and a transiently bad mirror gets a second chance instead of jamming the queue. The 30-minute step cap from #817 stays as the backstop.what was tested
make memcheckwith no apt output; the localmake memcheckon the same tree ran fully clean (all cases), confirming the wedge is the install preamble, not the suite. The retry/timeout wrapper is standard shell; this PR's own CI run exercises the changed step.